Skip to content

Conversation

@aljo242
Copy link
Contributor

@aljo242 aljo242 commented Oct 2, 2025

No description provided.

@vladjdk vladjdk self-requested a review October 20, 2025 15:13
@aljo242 aljo242 marked this pull request as ready for review October 30, 2025 15:36
simapp/app_di.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your stance on the future of runtime if this is deleted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right know I see depinject module config and runtime still exist, and only the example on how to wire that app is deleted. Would you consider runtime legacy or deprecated then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a draft to explore some new ways to wire up an application. We have been hacking on a few approaches so nothing here is final.

TBD on whether we remove runtime, but in the future I would like us to have only one way to wire your application.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I am not commenting on the rest indeed, due the the big DRAFT in the PR title :D
but this direction looks very much like the deprecation of runtime (and prob depinject then).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally as the original author of depinject and runtime, I feel that it's unfortunate that we didn't either 1) fully migrate to depinject or 2) find a solution that was simpler and satisfactory for everyone. Dependency injection wouldn't have been my first choice for how to solve this because it introduces a level of non-linear magic, but given the complexity of initialization dependencies it was seen as the least bad approach. There were quite a number of working group calls that explored different options and ended up with the depinject approach. I don't know the full context of this new approach, but whatever it is, I suggest we carefully the consider prior work, why it is the way it is and its pros/cons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants